Repository navigation
fix: drop eslint-plugin-import from the TypeScript lint preset - #121
Merged
Merged
Conversation
The plugin peer range stops at ESLint 9, so installs kept the unsupported ESLint 9.39.5 release.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
hieu-w
approved these changes
Nov 4, 2026
lionellbriones
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
eslint-plugin-import2.32.0 accepts ESLint only through version 9. That peer range made npm install ESLint 9.39.5. That release is no longer supported. ESLint 9 also pulledminimatchinto the lockfile.Jira Link
N/A
Description
Remove
eslint-plugin-importand theimport-js/no-extraneous-dependenciesrule from@toruslabs/oxlint-config-typescript. The native Oxlintimportplugin stays. Bumpeslint-plugin-tsdocto 0.5.4. The lockfile now resolves ESLint 10.14.0 for the remaining ESLint peers. The root package manager pin moves to npm 12.2.1, andoxlint-tailwindcssmoves to 1.17.1.How has this been tested?
vp test packages/oxlint-config-typescript/index.test.ts(5 tests passed)vp linton the changed TypeScript filesvp fmt --checkon the changed TypeScript files and the changesetScreenshots (if appropriate)
N/A
Types of changes
Checklist
Note
Medium Risk
Consumers lose
no-extraneous-dependenciesenforcement from this preset; dependency resolution shifts away from ESLint 9, which affects anyone relying on the old lint behavior or lockfile ESLint version.Overview
Removes
eslint-plugin-importfrom@toruslabs/oxlint-config-typescriptso installs no longer pull in unsupported ESLint 9 via that plugin’s peer range. The preset still uses Oxlint’s built-inimportplugin; only the JS bridge pluginimport-jsand theimport-js/no-extraneous-dependenciesrule are gone, so dev-vs-prod dependency checks from that rule no longer run.eslint-plugin-tsdocis bumped to 0.5.4. Root tooling pins npm 12.2.1 andoxlint-tailwindcss^1.17.1. Tests were updated to match the slimmerjsPluginslist and removed extraneous-deps expectations.Reviewed by Cursor Bugbot for commit 873478c. Bugbot is set up for automated code reviews on this repo. Configure here.